Skip to content

Add an isr route to the playground #367

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 11, 2025
Merged

Add an isr route to the playground #367

merged 3 commits into from
Feb 11, 2025

Conversation

vicb
Copy link
Contributor

@vicb vicb commented Feb 11, 2025 •
edited
Loading

This works as epxected with pnpm dev (Next server):

http://localhost:3000/isr/1 (and 2, 3) returns the page, 4 and up return a 404

with pnpm preview, http://localhost:8787/isr/N always return a 404

[wrangler:inf] GET /isr/1 404 Not Found (69ms)

@conico974 any idea what's going on here?

@changeset-bot
Copy link

changeset-bot bot commented Feb 11, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: 6fae1b0

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@pkg-pr-new
Copy link

pkg-pr-new bot commented Feb 11, 2025 •
edited
Loading

Open in Stackblitz

pnpm add https://pkg.pr.new/@opennextjs/cloudflare@367

commit: 6fae1b0

@conico974
Copy link
Collaborator

conico974 commented Feb 11, 2025 •
edited
Loading

@vicb One thing that i could think of here is that the ISR cache is not preloaded. If it's not it will return a 404

opennextjs-cloudflare/examples/playground/open-next.config.ts

Line 9 in b4309ee

incrementalCache: "dummy",

@vicb
Copy link
Contributor Author

vicb commented Feb 11, 2025

@vicb One thing that i could think of here is that the ISR cache is not preloaded. If it's not it will return a 404

opennextjs-cloudflare/examples/playground/open-next.config.ts

Line 9 in b4309ee

incrementalCache: "dummy",

💯, that was the issue here, thanks!

I'll update the PR.

@vicb
Copy link
Contributor Author

vicb commented Feb 11, 2025

Thanks @conico974 for figuring out the issue.

I added PR to enable the cache and add tests

conico974
conico974 reviewed Feb 11, 2025
View reviewed changes
@vicb vicb mentioned this pull request Feb 11, 2025
Closed
@vicb
Copy link
Contributor Author

vicb commented Feb 11, 2025

Thanks Nico for figuring out the issue here!

@vicb vicb merged commit 762d487 into main Feb 11, 2025
7 checks passed
@vicb vicb deleted the ISR branch February 11, 2025 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@conico974 conico974 conico974 approved these changes

@james-elicx james-elicx Awaiting requested review from james-elicx

@dario-piotrowicz dario-piotrowicz Awaiting requested review from dario-piotrowicz

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@vicb @conico974